Skip to content

Add unsigned retry for commit signing failures#6

Open
tim-smart wants to merge 5 commits into
t3code/add-direnv-shell-supportfrom
t3code/git-signing-toggle
Open

Add unsigned retry for commit signing failures#6
tim-smart wants to merge 5 commits into
t3code/add-direnv-shell-supportfrom
t3code/git-signing-toggle

Conversation

@tim-smart

@tim-smart tim-smart commented Jul 21, 2026

Copy link
Copy Markdown
Owner

Summary

  • Detect commit signing failures and expose a one-time unsigned retry for web and mobile Git actions.
  • Preserve feature-branch state during retries and pass --no-gpg-sign only for the retried commit.
  • Improve commit hook progress ordering and output attribution while avoiding leaked signing diagnostics.
  • Clear stale toast actions while Git operations are running.
  • Add contract, client-runtime, VCS, and Git manager coverage for signing failures and retry behavior.

Testing

  • Not run (PR content generated from the provided diff).
  • Added focused tests for signing-failure classification, unsigned commits, feature-branch retries, hook failures, progress ordering, and hook-output attribution.

@tim-smart
tim-smart force-pushed the t3code/git-signing-toggle branch 3 times, most recently from 1ebb4e4 to 82558fc Compare July 23, 2026 21:09
tim-smart added a commit that referenced this pull request Jul 23, 2026
@tim-smart
Add unsigned retry for commit signing failures (#6)
95de160
tim-smart added a commit that referenced this pull request Jul 24, 2026
@tim-smart
Add unsigned retry for commit signing failures (#6)
45ce747
@tim-smart
tim-smart force-pushed the t3code/git-signing-toggle branch from 82558fc to 63e8682 Compare July 24, 2026 00:44
tim-smart added a commit that referenced this pull request Jul 24, 2026
@tim-smart
Add unsigned retry for commit signing failures (#6)
e87200e
tim-smart added a commit that referenced this pull request Jul 24, 2026
@tim-smart
Add unsigned retry for commit signing failures (#6)
57f2c88
@tim-smart
tim-smart force-pushed the t3code/git-signing-toggle branch 2 times, most recently from c7907a7 to 90c665d Compare July 24, 2026 03:34
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Jul 24, 2026
@tim-smart
tim-smart changed the base branch from main to t3code/add-direnv-shell-support July 24, 2026 03:34
@tim-smart
tim-smart force-pushed the t3code/git-signing-toggle branch from 90c665d to d12869b Compare July 24, 2026 08:52
@github-actions github-actions Bot added size:L and removed size:XXL labels Jul 24, 2026
@github-actions
github-actions Bot force-pushed the t3code/add-direnv-shell-support branch from 1a7901d to d786974 Compare July 24, 2026 09:40
@github-actions
github-actions Bot force-pushed the t3code/git-signing-toggle branch from d12869b to 4479869 Compare July 24, 2026 09:40
@github-actions
github-actions Bot force-pushed the t3code/add-direnv-shell-support branch from d786974 to 41540af Compare July 24, 2026 14:12
@github-actions
github-actions Bot force-pushed the t3code/git-signing-toggle branch from 4479869 to 47379f1 Compare July 24, 2026 14:12
@tim-smart
tim-smart force-pushed the t3code/add-direnv-shell-support branch from 41540af to 8f5fc87 Compare July 25, 2026 10:26
@tim-smart
tim-smart force-pushed the t3code/git-signing-toggle branch from 47379f1 to 7d65c5a Compare July 25, 2026 10:26
@patroza patroza mentioned this pull request Jul 26, 2026
Draft
@github-actions
github-actions Bot force-pushed the t3code/git-signing-toggle branch from 7d65c5a to 72b989f Compare July 27, 2026 04:02
@github-actions
github-actions Bot force-pushed the t3code/add-direnv-shell-support branch from 8f5fc87 to 0e0d786 Compare July 27, 2026 04:02
tim-smart added 5 commits July 27, 2026 10:08
@tim-smart @github-actions
Add unsigned commit retry for signing failures
3222783 
- Detect commit signing failures across server and client
- Let stacked git actions retry once with signing disabled
- Preserve unsigned commit behavior in commit, push, and PR flows
@tim-smart @github-actions
Clear toast actions while Git operations run
6b298ff 
- Prevent stale action controls from appearing on Git progress toasts
@tim-smart @github-actions
Address commit signing retry feedback
59a6282
@tim-smart @github-actions
Fix commit hook progress ordering
3e78423
@tim-smart @github-actions
Preserve commit hook output attribution
24be1f5
@github-actions
github-actions Bot force-pushed the t3code/add-direnv-shell-support branch from 0e0d786 to 70f615d Compare July 27, 2026 10:08
@github-actions
github-actions Bot force-pushed the t3code/git-signing-toggle branch from 72b989f to 24be1f5 Compare July 27, 2026 10:08
patroza pushed a commit to patroza/t3code that referenced this pull request Jul 27, 2026
@tim-smart @github-actions
feat(tim): import tim-smart#6
37f8223 
Add unsigned retry for commit signing failures

Source: tim-smart#6
Source head: 7d65c5a
Source commits: 18ee567,72a6fae23c86708080c4fed346d5bf0f136f0221,6614b28239ed2330a8f601357a413f2d50da195a,ec169369daa554541511aa28f551b36f3dd26485,7d65c5a224e97a6b811b0a84892f1fda065c5963
Imported: complete product delta from the source PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size:L vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tim-smart